Conversation
Owner
Author
|
Superseded by pingdotgg#12870 — the implementation PR now lives upstream against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A truncated markdown preview could allow task-checkbox edits that replace the full file with only the displayed content. Disable editing for read-only or truncated previews and recheck authoritative cached content at the mutation boundary. Missing raw read data and optimistic drafts alone cannot authorize writes; complete content preserves the existing save path.
Stacked on the proposed contract: pingdotgg#12666. Native markdown previews are already read-only and do not gain editing here.
Validation: 38 focused tests across 6 files passed, including 7 mutation-boundary cases; web typecheck and scoped lint exited 0. A direct SWE-2 Max review (
devin -p --model swe-2-max) was attempted on the frozen diff but remained wholly silent; its captured process was stopped with SIGINT and exited 1 without a verdict. No completed independent review is claimed.Runtime proof (2026-09-20, isolated proof app; base d6f2913 vs this branch): on a 1,099,741-byte markdown fixture past the read limit, clicking a task checkbox in the rendered truncated preview writes the truncated body back on base (file shrank to 1,048,576 bytes); on this branch the checkboxes are disabled and the file size and sha256 are unchanged after clicks.
Before: https://github.com/user-attachments/assets/ef03cca7-8b5d-446e-9297-850eba961a3b
After: https://github.com/user-attachments/assets/f8efcef4-aa90-437c-a12b-2114eee596fc
Native markdown previews were already read-only; no native change is claimed.
Implemented by GPT-6 Astra medium in the Codex harness, informed by SWE-2 Max audit work. Manager handled focused checks and publication.