Repository navigation
Conversation
2 tasks done
Owner
Author
|
Superseded by pingdotgg#12867 — the implementation PR now lives upstream against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Secondary web views could ignore an explicit 12-hour/24-hour clock choice because they used raw locale formatters. Request-error times, provider-auth expiry, pull-request details, connection details and device-account updates now use the client's current preference. Full dates and existing seconds precision remain intact.
Why
This implements the audited web bypasses in the proposed clock-preference invariant. Cached formatter keys include preference and precision. Relative ages, durations, number/date-only formatting and machine timestamps keep their purpose. React Native has its own system-scoped preference model and is unchanged.
Stacked on
docs/consistency-clock-formatin the fork, independently of other invariant pairs.Validation
devin -p --model swe-2-maxindependent review exited 0: no actionable code bugs in the frozen formatter and consumer diff. It identified the missing runtime and before/after proof below; no merge-readiness claim.UI Changes
Runtime proof (2026-09-20, isolated proof app; base d6f2913 vs this branch): with Timestamp format set to 24-hour, the slow-request toast detail reads "Started 9:43:03 PM" on base and "Started 21:45:09" on this branch.
Before: https://github.com/user-attachments/assets/185e971d-c140-4209-abb6-910b67cd07e7
After: https://github.com/user-attachments/assets/6b818bb0-99a6-428a-b64d-77488cbe2936
Context: https://github.com/user-attachments/assets/8840b02b-c6d4-44c7-8a79-e60f86641e1a
The Connections pairing-link and PR-summary timestamp surfaces were not reachable on a loopback-only seeded environment; those paths are covered by the shared formatter tests.
Checklist
Implemented by GPT-6 Astra (medium reasoning) in Codex; independently reviewed by SWE-2 Max in Devin CLI.