Conversation
2 tasks done
Owner
Author
|
Superseded by pingdotgg#12865 — the implementation PR now lives upstream against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Message copy controls announced “Copy link” to screen readers while copying user or assistant message text. Their accessible name and tooltip now both say “Copy message”, including messages carrying structured context. The existing collapsed-message test expectation follows the corrected name.
Why
This implements the message-copy mismatch covered by the proposed action-names invariant. Other inspected code, plan and native message controls already identify their targets. This small fix does not claim whole-app compliance.
This implementation is stacked on
docs/consistency-action-namesin the fork; the documentation PR independently targets upstreammain.Validation
MessagesTimeline.test.tsx: 67 tests passed (CI=true vp test run --project unit src/components/chat/MessagesTimeline.test.tsx, fromapps/web).devin -p --model swe-2-maxwith a file-backed review prompt; read-only review included the repository coding standard.UI Changes
Runtime proof (2026-09-20, isolated proof app; base d6f2913 vs this branch): the message action buttons expose
aria-label="Copy link"on base andaria-label="Copy message"on this branch (DOM accessible-name observations; baseline interaction capture below).Before: https://github.com/user-attachments/assets/71591567-9fb2-4df5-a232-25eb28f6c00b
After-state evidence is the DOM observation plus a captured context screenshot in the session artifacts; the visible change is the accessible name, not layout.
Checklist
Implemented by GPT-6 Astra (low reasoning) in Codex; independently reviewed by SWE-2 Max in Devin CLI.