Repository navigation
Fix artifact export throughput and extend capture to ten minutes - #47
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed native Turns could fail while capturing generated files because short exporter reads caused hundreds of sequential transport round trips. Capture also had a three-minute limit, while the read-only preparation could expire during a longer export.
Coalesce exporter reads into the existing 64 KiB chunks and prefetch at most one receipt while storing the current chunk. Use one ten-minute capture budget across Core, gateway and Runtime, retain cancellation and atomic publication, and accept only confirmed, error-free read-only expiration as cleanup. Preserve production beta observations and measure prefetched requests from their actual send time.
Validation: focused dispatch, gateway and execution tests pass on the integrated beta snapshot, including existing observation tests. Virtual-clock tests cover a successful six-minute export, ten-minute expiration, earlier parent cancellation, release/shutdown and strict cleanup receipt ownership. Controlled MP4, PNG and 8 MiB ZIP fixtures preserve downloaded bytes and SHA-256. Focused race checks passed before beta integration; integrated checks and CI are required before release. The heavy timing fixture is not claimed as passing under race on the overloaded local host.
No public API fields, schema changes, partial-publication behavior or model replay. Deploy Core/Web and the matching Runtime template from the merged beta SHA. Existing allocations remain pinned. The companion Lab download fix is delivered separately.