Repository navigation
Enable turn auto retries by default (3) - #46
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
core.turn_auto_retries(OAC_TURN_AUTO_RETRIES) default to3so automatic turn retry (#45) is on without a separate deploy-time setting. The startup settings table now shows3as the default.Behaviour
3. This matters because compose and CI vars pass an unset value as an empty string.0: retry off. This is the rollback path.1..5: used as given.Docs (en and zh), compose, the Kubernetes README,
deploy.ymland tests are updated to match. The retry logic itself is unchanged.Rollback
Set
OAC_TURN_AUTO_RETRIES=0and restart Core. No migration.Testing
Build, vet, processconfig and execution tests, the retry tests, compose test,
make check-names,make check-ciandmake check-website(zhsource_hashrecomputed) pass locally. Database integration tests were skipped locally (noOAC_TEST_DATABASE_URL).Not verified: that a follow-up message continues the original conversation against a real database. The first real failure after deploy is that check.