feat: add configurable git identity inputs to vscode-publish-extensions - #168
Merged
Conversation
TypeScript 6 upgrade added scripts/tsconfig.json that now type-checks scripts/. Convert JS files to TS to resolve TS7016 (missing declarations) and TS7006 (implicit any) errors. Changes: - scripts/change-log-constants.js → .ts (ES modules) - scripts/change-log-generator-utils.js → .ts (typed interfaces) - scripts/create-release-notes.ts: add type to validateReleaseBranch param - Remove unused RELEASE_BRANCH_PREFexport (knip) - Update skill docs to reference .ts files Functionality preserved - only adds type safety. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Addresses code review findings: - Add validation to prevent empty string inputs from overriding defaults - Use git environment variables instead of git config for safer parameter passing - Prevents "empty ident name not allowed" errors when inputs are empty - Eliminates potential shell injection via GIT_AUTHOR_* environment variables Changes: - Validate git-user-name and git-user-email inputs before use - Fall back to workflow defaults if inputs are empty strings - Replace git config commands with GIT_AUTHOR_* and GIT_COMMITTER_* env vars - Add warning messages when falling back to defaults Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
madhur310
changed the title
madhur310
added a commit
to forcedotcom/salesforcedx-vscode
that referenced
this pull request
Aug 5, 2026
Temporarily reference feat/configurable-git-identity branch to test the new git-user-name/git-user-email inputs before the upstream PR merges to main. This commit should be reverted once salesforcecli/github-workflows#168 merges.
madhur310
added a commit
to forcedotcom/salesforcedx-vscode
that referenced
this pull request
Aug 5, 2026
Change back to using @main branch instead of feature branch now that salesforcecli/github-workflows#168 has the necessary changes.
kylewalke
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configurable git user identity to the vscode-publish-extensions reusable workflow, allowing callers to specify the commit author for version bump commits.
What does this PR do?
Adds two optional workflow inputs to
.github/workflows/vscode-publish-extensions.yml:git-user-name: Git user name for version bump commits (default: 'GitHub Action')git-user-email: Git user email for version bump commits (default: 'action@github.com')Changes:
git-user-nameandgit-user-emailoptional inputs with backward-compatible defaultsGIT_AUTHOR_*andGIT_COMMITTER_*environment variables for safer parameter passingWhy?
Previously, the workflow hardcoded the git identity as 'GitHub Action action@github.com'. This change allows callers to specify a different identity (e.g., 'Release Bot' via
getGithubUserInfoaction) while maintaining backward compatibility with existing callers through sensible defaults.Backward Compatibility
✅ Fully backward compatible - inputs are optional with defaults matching the previous hardcoded values. Existing workflows calling this reusable workflow will continue to work without modifications.