Repository navigation
fix(review): schema-peek masks locale-flagged headings, fails closed - #166
Merged
Merged
Conversation
Closes the follow-up noted in #159. The schema helper now reads phi_environment.locale from the machine-local config (worktree first, then the main checkout), masks headings matching the active locale's column patterns like any other identifier heading, and refuses to print (LocaleError, exit 1) on a malformed or unknown pack. All three copies stay identical; boundary-doc sections updated in step. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 7
✨ Finishing Touches
Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the follow-up noted in #159: the schema helper now participates in locale masking. It reads
phi_environment.localefrom the machine-local config (worktree first, then the main checkout, mirroring the guard), masks headings matching the active locale's column patterns exactly like other identifier headings, and fails closed on a malformed or unknown pack —LocaleError, exit 1, nothing printed. All three script copies stay byte-identical; the three boundary-doc sections gained the same sentence in step.Validation
bun test tests/data-boundary-locale.test.ts— new cases: masked under uk, shown without locale, unknown locale refuses to printbun testgreen;bun run release:validatein syncCloses #159 (follow-up note).
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
schema-peek.pymasks headings that match the active locale’s column patterns.phi_environment.localefrom machine-local configuration. It leaves headings unchanged when no locale is configured and fails closed withLocaleErrorfor an unknown or malformed locale pack.bun testandbun run release:validatepassed.