Skip to content

fix(review): schema-peek masks locale-flagged headings, fails closed - #166

Merged
sajor2000 merged 1 commit into
mainfrom
feat/schema-peek-locale-masking
Oct 22, 2026
Merged

sajor2000 merged 1 commit into
mainfrom
feat/schema-peek-locale-masking

Conversation

@sajor2000

@sajor2000 sajor2000 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

What

Closes the follow-up noted in #159: the schema helper now participates in locale masking. It reads phi_environment.locale from the machine-local config (worktree first, then the main checkout, mirroring the guard), masks headings matching the active locale's column patterns exactly like other identifier headings, and fails closed on a malformed or unknown pack — LocaleError, exit 1, nothing printed. All three script copies stay byte-identical; the three boundary-doc sections gained the same sentence in step.

Validation

  • bun test tests/data-boundary-locale.test.ts — new cases: masked under uk, shown without locale, unknown locale refuses to print
  • Full bun test green; bun run release:validate in sync

Closes #159 (follow-up note).

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

  • schema-peek.py masks headings that match the active locale’s column patterns.
  • The script reads phi_environment.locale from machine-local configuration. It leaves headings unchanged when no locale is configured and fails closed with LocaleError for an unknown or malformed locale pack.
  • Updated locale documentation and added tests for UK masking, visibility without a configured locale, and fail-closed behavior.
  • Validation reported: bun test and bun run release:validate passed.
Contributing author Lines added Lines removed
JC Rojas 345 16

Closes the follow-up noted in #159. The schema helper now reads
phi_environment.locale from the machine-local config (worktree first,
then the main checkout), masks headings matching the active locale's
column patterns like any other identifier heading, and refuses to print
(LocaleError, exit 1) on a malformed or unknown pack. All three copies
stay identical; boundary-doc sections updated in step.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 457938bd-0727-40f3-980c-a4e0308b23ab
📥 Commits

Reviewing files that changed from the base of the PR and between 3bb0129 and f43c89d.

📒 Files selected for processing: 7
  • README.md
  • docs/setup.md
  • plugins/methodsmith/README.md
  • plugins/methodsmith/scripts/schema-peek.py
  • plugins/methodsmith/skills/method-setup/scripts/schema-peek.py
  • plugins/methodsmith/skills/method-work/scripts/schema-peek.py
  • tests/data-boundary-locale.test.ts
+---------------------------------------+
| Feature flags up; bug sightings down. |
+---------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sajor2000
sajor2000 merged commit 7f356ed into main Oct 22, 2026
2 of 3 checks passed
@sajor2000
sajor2000 deleted the feat/schema-peek-locale-masking branch October 22, 2026 14:44
@github-actions github-actions Bot mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant