Repository navigation
feat(guidelines): publish machine-checked third-party notices file - #149
Merged
Merged
Conversation
MedSci audit gap #10 (docs/audits/2026-10-19-medsci-skills-competitive-audit.md): parity on a consolidated THIRD-PARTY-NOTICES.md checked against the tree. - scripts/docs/third-party-notices.ts renders the file from guideline-registry.yaml plus each checklist's source-and-licence header; classification is fail-closed (a header stating neither verbatim wording nor a faithful paraphrase fails generation), and mixed-licence sources (open-licence checklist inside a restricted article) keep their full statement. Run: bun run docs:third-party-notices [--check]. - tests/third-party-notices-doc.test.ts regenerates the page and fails on drift, requires every registry guideline to appear once with its DOI and checklist link, pins every restricted source to the restricted section, and exercises both fail-closed paths. - AGENTS.md documents the generated file next to docs/guideline-sources.md. Validation: bun test (1734 pass / 11 skip / 0 fail), bunx tsc --noEmit, release:validate in sync (55 agents, 67 skills). Closes #148 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 5
✨ Finishing Touches
Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a consolidated, machine-checked
THIRD-PARTY-NOTICES.md— MedSci audit gap #10 (medium-impact parity item fromdocs/audits/2026-10-19-medsci-skills-competitive-audit.md).scripts/docs/third-party-notices.ts(new): rendersTHIRD-PARTY-NOTICES.mdfromguideline-registry.yamlplus the bolded source-and-licence header every bundled checklist must carry.bun run docs:third-party-noticeswrites it;--checkfails on drift (CI-ready).tests/third-party-notices-doc.test.ts(new): the file matches the generator (drift check), all 49 registry guidelines appear exactly once with DOI + checklist link, every restricted source is pinned to the restricted section, and both fail-closed paths are covered.AGENTS.md: documents the generated file next todocs/guideline-sources.md.package.json: adds thedocs:third-party-noticesscript.Current output: 49 checklists — 21 quote item text verbatim under open terms, 28 are faithful paraphrases; 29 restricted or mixed-licence sources carry their full header statement.
Why
The audit (gap #10) found the competitor ships a
THIRD-PARTY-NOTICES.mdchecked on every build while our licence status was scattered across per-checklist headers. This makes the licence posture visible in one file and enforced bybun test, without changing any checklist content.Closes #148
Validation
bun test— 1734 pass / 11 skip / 0 fail (full suite)bunx tsc --noEmit— cleanbun run release:validate— in sync (55 agents, 67 skills, 0 MCP servers); no release-owned files touchedTHIRD-PARTY-NOTICES.mdfor 49 bundled checklists.bun run docs:third-party-noticesand--checksupport.AGENTS.md.