Skip to content

rand v0.9.5: backport #1790 - #1803

Merged
dhardy merged 2 commits into
0.9from
push-tqkwtkvprnpn
Jul 11, 2026
Merged

rand v0.9.5: backport #1790#1803
dhardy merged 2 commits into
0.9from
push-tqkwtkvprnpn

Conversation

@dhardy

@dhardy dhardy commented Jul 2, 2026

Copy link
Copy Markdown
Member
  • Added a CHANGELOG.md entry

Summary

Backport #1790 to rand 0.9.5.

Motivation

This changes address an unsoundness issue: code like the following could yield a Distribution object yielding invalid char values when sampled (unsound):

        let json = r#"{"sampler":{"low":4294967200,"range":0,"thresh":0}}"#;
        let result = serde_json::from_str::<Uniform<char>>(json);

@dhardy
Backport #1790: Check UniformChar validity on deser
bc36dbc 
Prevent memory safety violation in `UniformChar` via deserialization.
@dhardy
dhardy requested a review from tarcieri July 2, 2026 09:55
@dhardy
dhardy force-pushed the push-tqkwtkvprnpn branch from 3a5d941 to c458814 Compare July 2, 2026 09:59
@dhardy
dhardy merged commit 3474ec0 into 0.9 Jul 11, 2026
13 checks passed
@dhardy
dhardy deleted the push-tqkwtkvprnpn branch July 11, 2026 11:13
This was referenced Jul 27, 2026
Closed
Closed
Open
Open
@elvis-sik elvis-sik mentioned this pull request Jul 30, 2026
Merged
elvis-sik added a commit to baixada-cards/truco-solver that referenced this pull request Jul 31, 2026
@elvis-sik @claude
build(deps): migrate to rand 0.9 and bincode 2, preserving the v1 wir…
47206f2 
…e format (#14)

Replaces #9 (Dependabot could only bump the versions; both bumps are
breaking and needed an API migration).

## rand 0.8.7 → 0.9.5

- `rng.gen()` → `rng.random()`, `rng.gen::<bool>()` →
`rng.random::<bool>()`, `rand::thread_rng()` → `rand::rng()`.
`StdRng::seed_from_u64` is unchanged.
- Security value: 0.9.5 includes the `UniformChar` deserialization
memory-safety fix (rust-random/rand#1803). 0.8.7 is the last 0.8.x
release, so there is no patched 0.8 — 0.9 is the only way to pick the
fix up.
- **Seeded reproducibility is preserved.** rand 0.8.7 and 0.9.5
`StdRng::seed_from_u64` produce bit-identical streams for the three draw
shapes this crate uses (`next_u64`, `f64`, `bool`), verified across
seeds 0/1/42/12345/u64::MAX. Previously recorded seeded `mccfr-bench`
results stay reproducible.

### Note: rand 0.8.7 is still linked, via truco-engine

`cargo tree -i rand@0.8.7 -e normal` shows it arriving as a **normal**
dependency of the pinned `truco-engine` rev, not as a dev-only
dependency — so solver binaries link both 0.8.7 and 0.9.5. That is sound
(the two RNGs are never passed across the engine boundary; the workspace
compiles and all tests pass), but it means the memory-safety fix is only
adopted for this crate's own RNG use, not the engine's.

Fully retiring rand 0.8 needs a coordinated bump: `truco-engine` and
`truco-server` deliberately pin `rand < 0.9` in their Dependabot configs
("must move with bots/server consumers to keep one RNG trait ABI"), and
the rand PRs in engine/server/bots were all closed unmerged. That
multi-repo migration is out of scope here and should be tracked
separately.

## bincode 1.3.3 → 2.0.1

bincode 2 removed the free functions (`serialize`, `serialize_into`,
`deserialize`, `deserialize_from`) and its new default config is
varint-encoded — a naive port would silently orphan every existing
artifact (GCS checkpoints, treepacks, teacher sidecars, match-value
tables).

Instead, all bincode traffic now goes through a new `bincode_v1` module
that wraps `bincode::serde` with `bincode::config::legacy()`
(little-endian, fixed-width integers, no limit) — bincode 1's exact
default wire format. Call sites are unchanged apart from the module
path.

## Compatibility verification

- **Scratch parity harness** (bincode 1.3.3 and 2.0.1 side by side):
byte-identical output for representative shapes (data-carrying enums,
tuples, `Option`, `String`, `Vec<f64>/<f32>`, fixed arrays, smallvec,
sequential multi-value streams), cross-decode in both directions,
trailing-bytes tolerance (the legacy-layout fallback decodes rely on
it).
- **Golden bytes in-tree**: `bincode_v1` tests assert against a byte
vector produced by real bincode 1.3.3 pre-migration, so any future
format drift fails CI.
- **Real GCS artifacts** decoded with the migrated code:
- `10x10-full-20260709/match_values.bin`: decoded and re-encoded
**byte-identically** (3,042 bytes).
- `10x10-full-20260709/.../tc0.d0.ckpt.bin` (6.7 GB, range-read prefix):
`CheckpointMeta` decodes correctly (score (10,10), SyncCFR+, iter 910,
39,508,752 info sets, dealer_filter Some(0)) and 48,991 streamed entries
decode with consistent action/regret/strategy lengths, all values
finite.
- `deep-probe-0x0-tc0-d0-20260721/checkpoint/deep-0x0-d0.ckpt` (15.7 GiB
resume asset, range-read header): leading scalars decode to the known
run config (0x0 tc0 d0, round 3 of 3, 140,118 deals, 3,135 subgames).

`make check` passes (locks, fmt, clippy -D warnings, full workspace
tests, autoresearch).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Elvis Sikora <11654926+elvis-sik@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@cursor cursor Bot mentioned this pull request Aug 5, 2026
Open
renovate Bot added a commit to gwennlbh/shapemaker that referenced this pull request Sep 27, 2026
@renovate
⬆️ Update Rust crate rand to 0.10.3
e57f4bb 
##### [v0.10.3](https://github.com/rust-random/rand/blob/HEAD/CHANGELOG.md#0103--2026-09-20)

##### Fixes

- Fix `WeightedIndex` panic when the sum of float weights is infinite; return `Error::Overflow` instead ([#1808])
- Fix spurious `Error::NonFinite` from `Uniform::new_inclusive` on large finite float ranges such as `0.0..=f64::MAX` ([#1821])
- Fix possible panic due to sampling a deserialized `Uniform<char>` ([#1831])

##### Changes

- Report exact remaining lengths from `WeightedIndex::weights()` and reduce overhead when reading weights ([#1838])

[#1808]: rust-random/rand#1808

[#1821]: rust-random/rand#1821

[#1831]: rust-random/rand#1831

[#1838]: rust-random/rand#1838
##### [v0.10.2](https://github.com/rust-random/rand/blob/HEAD/CHANGELOG.md#0102--2026-07-02)

##### Fixes

- Fix possible memory safety violation due to deserialization of `UniformChar` from bad source ([#1790])

##### Changes

- Document required output order of fn `partial_shuffle` and apply `#[must_use]` ([#1769])
- Avoid usage of `unsafe` in contexts where non-local memory corruption could invalidate contract ([#1791])

[#1769]: rust-random/rand#1769

[#1790]: rust-random/rand#1790

[#1791]: rust-random/rand#1791
##### [v0.10.1](https://github.com/rust-random/rand/blob/HEAD/CHANGELOG.md#0101--2026-02-11)

This release includes a fix for a soundness bug; see [#1763].

##### Changes

- Document panic behavior of `make_rng` and add `#[track_caller]` ([#1761])
- Deprecate feature `log` ([#1763])

[#1761]: rust-random/rand#1761

[#1763]: rust-random/rand#1763
##### [v0.10.0](https://github.com/rust-random/rand/blob/HEAD/CHANGELOG.md#0100---2026-02-08)

##### Changes

- The dependency on `rand_chacha` has been replaced with a dependency on `chacha20`. This changes the implementation behind `StdRng`, but the output remains the same. There may be some API breakage when using the ChaCha-types directly as these are now the ones in `chacha20` instead of `rand_chacha` ([#1642]).
- Rename fns `IndexedRandom::choose_multiple` -> `sample`, `choose_multiple_array` -> `sample_array`, `choose_multiple_weighted` -> `sample_weighted`, struct `SliceChooseIter` -> `IndexedSamples` and fns `IteratorRandom::choose_multiple` -> `sample`, `choose_multiple_fill` -> `sample_fill` ([#1632])
- Use Edition 2024 and MSRV 1.85 ([#1653])
- Let `Fill` be implemented for element types, not sliceable types ([#1652])
- Fix `OsError::raw_os_error` on UEFI targets by returning `Option<usize>` ([#1665])
- Replace fn `TryRngCore::read_adapter(..) -> RngReadAdapter` with simpler struct `RngReader` ([#1669])
- Remove fns `SeedableRng::from_os_rng`, `try_from_os_rng` ([#1674])
- Remove `Clone` support for `StdRng`, `ReseedingRng` ([#1677])
- Use `postcard` instead of `bincode` to test the serde feature ([#1693])
- Avoid excessive allocation in `IteratorRandom::sample` when `amount` is much larger than iterator size ([#1695])
- Rename `os_rng` -> `sys_rng`, `OsRng` -> `SysRng`, `OsError` -> `SysError` ([#1697])
- Rename `Rng` -> `RngExt` as upstream `rand_core` has renamed `RngCore` -> `Rng` ([#1717])

##### Additions

- Add fns `IndexedRandom::choose_iter`, `choose_weighted_iter` ([#1632])
- Pub export `Xoshiro128PlusPlus`, `Xoshiro256PlusPlus` prngs ([#1649])
- Pub export `ChaCha8Rng`, `ChaCha12Rng`, `ChaCha20Rng` behind `chacha` feature ([#1659])
- Fn `rand::make_rng() -> R where R: SeedableRng` ([#1734])

##### Removals

- Removed `ReseedingRng` ([#1722])
- Removed unused feature "nightly" ([#1732])
- Removed feature `small_rng` ([#1732])

[#1632]: rust-random/rand#1632

[#1642]: rust-random/rand#1642

[#1649]: rust-random/rand#1649

[#1652]: rust-random/rand#1652

[#1653]: rust-random/rand#1653

[#1659]: rust-random/rand#1659

[#1665]: rust-random/rand#1665

[#1669]: rust-random/rand#1669

[#1674]: rust-random/rand#1674

[#1677]: rust-random/rand#1677

[#1693]: rust-random/rand#1693

[#1695]: rust-random/rand#1695

[#1697]: rust-random/rand#1697

[#1717]: rust-random/rand#1717

[#1722]: rust-random/rand#1722

[#1732]: rust-random/rand#1732

[#1734]: rust-random/rand#1734
##### [v0.9.5](https://github.com/rust-random/rand/releases/tag/0.9.5)

#### What's Changed

- rand v0.9.5: backport [#1790](rust-random/rand#1790) by [@dhardy](https://github.com/dhardy) in [#1803](rust-random/rand#1803)

**Full Changelog**: <rust-random/rand@0.9.4...0.9.5>
##### [v0.9.4](https://github.com/rust-random/rand/releases/tag/0.9.4)

##### Fixes

- Fix doc build ([#1766])

[#1766]: rust-random/rand#1766

**Full Changelog**: <rust-random/rand@0.9.3...0.9.4>
##### [v0.9.3](rust-random/rand@0.9.2...0.9.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vks vks vks approved these changes
@tarcieri tarcieri Awaiting requested review from tarcieri

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhardy @vks