refactor(test/mock-bin): extract generic environment variable echo option - #5064
Conversation
Co-authored-by: rami3l <rami3l@outlook.com>
097153d to
f217932
Compare
|
In rustls we enforce format style in CI by using nightly clippy: https://github.com/rustls/rustls/blob/main/.github/workflows/build.yml#L392 Maybe that could make sense for rustup? |
@djc If you mean nightly Regarding the following minimal unstable_features = true
group_imports = "StdExternalCrate"
imports_granularity = "Crate" |
|
The key here is that we don't want the CI to break way too frequently which may slow down both merging and releases. But otherwise, having a consistent style everywhere would be super cool, I agree. |
Yes, these have been very stable IME. (I don't think you need |
This PR is mainly cherry-picked from #5056 as suggested in #5056 (comment).
Also, since my project goal prototype branch will be modifying
distfiles a lot, I've used this opportunity to clean up the imports indistas well.