Skip to content

fix(cli/self-update): stop emitting cargo metadata in warn_if_default_linker_missing() - #5061

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:fix/cc-cargo-meta
Sep 7, 2026
Merged

fix(cli/self-update): stop emitting cargo metadata in warn_if_default_linker_missing()#5061
rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:fix/cc-cargo-meta

Conversation

@rami3l

@rami3l rami3l commented Sep 7, 2026

Copy link
Copy Markdown
Member

Closes #5059.

Because the output varies from platform to platform, and the influence being purely cosmetic, it is quite tricky to do a full regression test I think?

The regression itself is from the migration to cc-rs in #4807 so many thanks for @ermakov0's pointers.

@rami3l
rami3l requested a review from djc September 7, 2026 09:39
@rami3l
rami3l enabled auto-merge September 7, 2026 09:43
@rami3l
rami3l added this pull request to the merge queue Sep 7, 2026
Merged via the queue into rust-lang:main with commit 1420639 Sep 7, 2026
31 checks passed
@rami3l
rami3l deleted the fix/cc-cargo-meta branch September 7, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warn_if_default_linker_missing contains surprising lines "cargo:rerun-if-env-changed"

2 participants