rustup-init leaves user with colored terminal

[Vbbab]

(If this doesn't belong here, please tell me which repo to move it to, thanks!)

Problem

rustup's setup script, rustup-init, leaves the user with a colored terminal when exiting interrupted.

Steps

1. Execute rustup-init
2. At the first prompt, interrupt by Ctrl-C
3. User's shell is now red.

Possible Solution(s)
Check the interrupted-exit code maybe? Make sure that the color is reset before exiting (Since ^C is displayed in red)

Notes

OS: Win 10 (1909)
Output of rustup --version: rustup 1.23.0 (00924c9ba 2020-11-27)
Output of rustup-init --version: rustup-init 1.22.1 (b01adbbc3 2020-07-08)
Output of rustup show:

Default host: x86_64-pc-windows-msvc
rustup home:  C:\Users\kangj\.rustup

installed toolchains
--------------------

stable-x86_64-pc-windows-msvc
nightly-x86_64-pc-windows-msvc (default)

active toolchain
----------------

nightly-x86_64-pc-windows-msvc (default)
rustc 1.48.0-nightly (6af1bdda5 2020-09-15)

[kinnison]

Thank you for your report, I shall try and reproduce this tonight. If anyone else reads this and knows what might be going on, please comment on the issue, I'm not a Windows developer by default.

[toothbrush7777777]

I've run into this before. It happens because conhost doesn't reset the terminal colours after a program is terminated.
I think bash and most other terminals & shells resets the colour automatically.

[kinnison]

What's odd is that there's no red in the rustup output at that point. So I wonder what we've done to the terminal that is causing that.

[Vbbab]

Perhaps the Interrupt is colored (^C)?

[Vbbab]

Oh and it appears that the bug only reproduces if you wait a few seconds at the first prompt. In that case the interrupt is red.

Waiting up to 4 seconds before interrupting will actually show the beginning of an error, which could be why it's red...

[kinnison]

What error is it showing at that point? can you attach a screenshot?

[Vbbab]

If I interrupt it at exactly 4 seconds, this error shows up, but is blank:

[kinnison]

Oh interesting, I wonder if the control+C managed to give it some input before it killed it.

[Vbbab]

but if I interrupt at different time intervals, things happen:

• Immediately: Regular white ^C, user shell is normal
• At 4 secs: error, red ^C, user shell is red
• Between 1-4 secs, and more than 4 secs: no error, red ^C, user shell is red

[kinnison]

That is extremely odd.

[Vbbab]

Could this be a bug with some sort of input-handling loop? Or maybe rustup-init is loading something within the initial 4 secs?

[kinnison]

I guess possibly. I'm not entirely sure how the input loop behaves on Windows.