rustdoc: fix few clippy lints

[klensy]

Fix few clippy lints: second commit - perf ones, first - other ones.

[rust-highfive]

Some changes occurred in clean/types.rs.

cc @camelid

[rust-highfive]

r? @notriddle

(rust-highfive has picked a reviewer for you, use r? to override)

[notriddle]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[notriddle]

@bors try

[bors]

⌛ Trying commit 2a326bc with merge b97085a9b3649bb3d50bbd3541a98c06017e01bf...

[bors]

☀️ Try build successful - checks-actions
Build commit: b97085a9b3649bb3d50bbd3541a98c06017e01bf (b97085a9b3649bb3d50bbd3541a98c06017e01bf)

[rust-timer]

Queued b97085a9b3649bb3d50bbd3541a98c06017e01bf with parent fa70b89, future comparison URL.

[rust-timer]

Finished benchmarking commit (b97085a9b3649bb3d50bbd3541a98c06017e01bf): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	1	2	0	1	1
mean2	2.9%	2.8%	N/A	-1.2%	2.9%
max	2.9%	4.4%	N/A	-1.2%	2.9%

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	0	2	0	6	0
mean2	N/A	2.3%	N/A	-6.8%	N/A
max	N/A	2.3%	N/A	-9.0%	N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. number of relevant changes ↩ ↩²

2. the arithmetic mean of the percent change ↩ ↩²

[notriddle]

Most of the "changes" to max-rss and cycles are in non-doc test targets, so they're probably spurious.

@bors r+

[bors]

📌 Commit 2a326bc has been approved by notriddle

[bors]

⌛ Testing commit 2a326bc with merge 6ac8ada...

[bors]

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 6ac8ada to master...

[rust-timer]

Finished benchmarking commit (6ac8ada): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	1	1	0	1	1
mean2	2.8%	1.1%	N/A	-2.4%	2.8%
max	2.8%	1.1%	N/A	-2.4%	2.8%

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	0	2	0	0	0
mean2	N/A	2.0%	N/A	N/A	N/A
max	N/A	2.0%	N/A	N/A	N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. number of relevant changes ↩ ↩²

2. the arithmetic mean of the percent change ↩ ↩²