Skip to content

Miri value validation: fix handling of uninit memory - #74059

Merged
bors merged 4 commits into
rust-lang:masterfrom
RalfJung:miri-uninit-validation
Jul 7, 2020
Merged

Miri value validation: fix handling of uninit memory#74059
bors merged 4 commits into
rust-lang:masterfrom
RalfJung:miri-uninit-validation

Conversation

@RalfJung

@RalfJung RalfJung commented Jul 5, 2020

Copy link
Copy Markdown
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2020
@RalfJung RalfJung mentioned this pull request Jul 5, 2020
Merged
@RalfJung

RalfJung commented Jul 5, 2020

Copy link
Copy Markdown
Member Author

The Miri side, including test cases, is at rust-lang/miri#1468.

This was referenced Jul 5, 2020
Closed
Closed
@oli-obk

oli-obk commented Jul 5, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 751b594 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2020
@RalfJung

RalfJung commented Jul 5, 2020

Copy link
Copy Markdown
Member Author

Fixed rustfmt.
@bors r=oli-obk

@bors

bors commented Jul 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 319c7f7 has been approved by oli-obk

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 6, 2020
@Manishearth
Rollup merge of rust-lang#74059 - RalfJung:miri-uninit-validation, r=…
2b3bc21 
…oli-obk

Miri value validation: fix handling of uninit memory

Fixes rust-lang/miri#1456
Fixes rust-lang/miri#1467

r? @oli-obk
@Manishearth Manishearth mentioned this pull request Jul 6, 2020
Closed
@bors

bors commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 319c7f7 with merge ee186cab341250cf90be51239688e89e4f419102...

@bors

bors commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2020
@RalfJung

RalfJung commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2020
@bors

bors commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 319c7f7 with merge 0772b2c5071f18f9e99bcd48744d4d4fdfeeafcb...

@bors

bors commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2020
@RalfJung

RalfJung commented Jul 7, 2020

Copy link
Copy Markdown
Member Author 
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/p/python-setuptools/python3-setuptools_20.7.0-1_all.deb  503  Service Unavailable

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2020
@bors

bors commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 319c7f7 with merge e1beee4...

@bors

bors commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing e1beee4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2020
@bors
bors merged commit e1beee4 into rust-lang:master Jul 7, 2020
@rust-highfive rust-highfive mentioned this pull request Jul 7, 2020
Closed
@rust-highfive

rust-highfive commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #74059!

Tested on commit e1beee4.
Direct link to PR: #74059

💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 7, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#74059!
2d5a0c1 
Tested on commit rust-lang/rust@e1beee4.
Direct link to PR: <rust-lang/rust#74059>

💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
bors added a commit to rust-lang/miri that referenced this pull request Jul 7, 2020
@bors
Auto merge of #1468 - RalfJung:uninit-validation, r=RalfJung
5e94f57 
Test uninit memory validation

This adds the tests for rust-lang/rust#74059.
@RalfJung
RalfJung deleted the miri-uninit-validation branch July 8, 2020 06:17
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.46

Development

Successfully merging this pull request may close these issues.

ICE around validation of bool and char ICE when calling mem::uninitialized for an enum with 256 variants.

5 participants

@RalfJung @oli-obk @bors @rust-highfive @cuviper