librustc: offer suggestions for unresolved names. - #5096
Closed
luqmana wants to merge 3 commits into
Closed
Conversation
Contributor
|
This looks really cool. |
Contributor
|
\o/ |
Contributor
Author
bors
added a commit
that referenced
this pull request
Feb 27, 2013
Address #2281 ``` -> % cat foo.rs fn foo() -> int { let bar = 10; bad } ``` ``` -> % rustc foo.rs foo.rs:4:4: 4:7 error: unresolved name: `bad`. Did you mean: `bar`? foo.rs:4 bad ^~~ error: aborting due to previous error ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Don't use ExpnKind::descr to get the name of a bang macro. This is the same change as the first commit in rust-lang#68407, but applied to clippy. The new code should work both before and after the changes in rust-lang#68407. changelog: none
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 12, 2026
fix spurious epoll-blocking test
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
5096: Fix handling of whitespace when applying SSR within macro expansions. r=matklad a=davidlattimore I originally did replacement by passing in the full file text. Then as some point I thought I could do without it. Turns out calling .text() on a node coming from a macro expansion isn't a great idea, especially when you then try and use ranges from the original source to cut that text. The test I added here actually panics without the rest of this change (sorry I didn't notice sooner). 5097: Fix SSR prompt following rust-lang#4919 r=matklad a=davidlattimore Co-authored-by: David Lattimore <dml@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #2281