Skip to content

revert using trans::Disr in LoadRangeAssert - #30996

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:fix/load_range_assert
Jan 18, 2016
Merged

revert using trans::Disr in LoadRangeAssert#30996
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:fix/load_range_assert

Conversation

@oli-obk

@oli-obk oli-obk commented Jan 18, 2016

Copy link
Copy Markdown
Contributor

it makes no sense here, accidentally introduced in #30931

r? @dotdash

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dotdash (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa

nagisa commented Jan 18, 2016

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 5081d4c has been approved by nagisa

@bors

bors commented Jan 18, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5081d4c with merge 84790fe...

@oli-obk
oli-obk force-pushed the fix/load_range_assert branch from 5081d4c to d5f790c Compare January 18, 2016 10:22
@oli-obk

oli-obk commented Jan 18, 2016

Copy link
Copy Markdown
Contributor Author

I forgot to remove a use, this will fail, it should be aborted.

@nagisa

nagisa commented Jan 18, 2016

Copy link
Copy Markdown
Member

@bors r-

@nagisa

nagisa commented Jan 18, 2016

Copy link
Copy Markdown
Member

@bors r+ retry force

@bors

bors commented Jan 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit d5f790c has been approved by nagisa

@bors

bors commented Jan 18, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d5f790c with merge d237506...

it makes no sense here, accidentally introduced in rust-lang#30931
@oli-obk
oli-obk force-pushed the fix/load_range_assert branch from d5f790c to c02ba16 Compare January 18, 2016 10:31
@nagisa

nagisa commented Jan 18, 2016

Copy link
Copy Markdown
Member

@bors r+ c02ba16 retry force

bors added a commit that referenced this pull request Jan 18, 2016
it makes no sense here, accidentally introduced in #30931

r? @dotdash
@bors

bors commented Jan 18, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c02ba16 with merge 50a8333...

@bors
bors merged commit c02ba16 into rust-lang:master Jan 18, 2016
@oli-obk
oli-obk deleted the fix/load_range_assert branch January 19, 2016 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants