Only check #[allow(dead_code)] on the trait - #161932
Merged
rust-bors[bot] merged 1 commit intoSep 8, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
mu001999
commented
Aug 28, 2026
| } | ||
| } | ||
|
|
||
| fn bar() {} //~ ERROR function `bar` is never used |
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
…uwer Rollup of 12 pull requests Successful merges: - #162462 (Fix unsoundness in `VecDeque::from_iter(vec::IntoIter)`) - #162468 (mir_build: Rename `lower_let_expr` to `lower_fallible_let`, and clarify) - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`) - #161912 (run `extern "tail"` with `byval` argument test) - #161932 (Only check `#[allow(dead_code)]` on the trait) - #162236 (Call renumberMetadataForAssembly() in LLVMRustPrintModule()) - #162435 (windows-gnu: document libgcc requirement) - #162439 (Update books) - #162451 (Add regression test for item-local diagnostic attribute lint levels) - #162455 (Update codegen-llvm/inline-debuginfo.rs for distinct DILocation) - #162459 (docs(time): replace "method" with "function") - #162465 (Fix my duplicate thanks entry)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
Rollup merge of #161932 - mu001999-contrib:dead-code-refactor, r=chenyukang Only check `#[allow(dead_code)]` on the trait I edited on an old branch (on another machine) when trying to resolve the first comment in #161571, and then force-pushed it. So it introduced the behavior in #157885 partially. I found this when rebasing #157885, and I was expecting a conflict about this. r? chenyukang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I edited on an old branch (on another machine) when trying to resolve the first comment in #161571, and then force-pushed it. So it introduced the behavior in #157885 partially.
I found this when rebasing #157885, and I was expecting a conflict about this.
r? chenyukang