Improve dangerous_implicit_aurorefs diagnostic output - #140768
Merged
Conversation
rustbot
added
S-waiting-on-review
Member
|
Not a good reviewer for this, maybe r? @RalfJung |
commented
May 8, 2025
Member
|
I'm not really an expert for lint implementations, and hardly use these HIR APIs. Let's see if this works |
RalfJung
reviewed
May 8, 2025
RalfJung
reviewed
May 8, 2025
Urgau
force-pushed
the
improv_autorefs-lint
branch
from
May 8, 2025 11:36
e4fac05 to
5e5cacd
Compare
fmease
reviewed
May 14, 2025
fmease
approved these changes
May 14, 2025
commented
May 14, 2025
Member
|
r? fmease |
This comment was marked as resolved.
This comment was marked as resolved.
fmease
added
S-waiting-on-author
Urgau
force-pushed
the
improv_autorefs-lint
branch
from
May 14, 2025 21:54
5e5cacd to
9b3abe7
Compare
fmease
reviewed
May 15, 2025
| lint_implicit_unsafe_autorefs = implicit autoref creates a reference to the dereference of a raw pointer | ||
| .note = creating a reference requires the pointer target to be valid and imposes aliasing requirements | ||
| .raw_ptr = this raw pointer has type `{$raw_ptr_ty}` | ||
| .autoref = autoref is being applied to this expression, resulting in: `{$autoref_ty}` |
Member
There was a problem hiding this comment.
We talked about rephrasing "autoref is being applied" to sth. along the lines of "references to this expression are implicitly created", "references are implicitly applied ...", ...
Is that still something we want to pursue?
Member
Author
There was a problem hiding this comment.
Yeah, I wanted to do that but given that the end result type is not going to have a visible reference I just removed the "autoref" note, and just show the deref one.
Urgau
added
S-waiting-on-review
commented
May 15, 2025
Member
|
@bors r+ rollup |
commented
May 15, 2025
Collaborator
commented
May 15, 2025
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR greatly improves the
dangerous_implicit_aurorefslint diagnostic output.Kind of related to #140721.
r? @jieyouxu (maybe)