Skip to content

annotate-snippet emitter: Deal with multispans in macros correctly #61810

Description

@phansch

Part of #59346

To properly handle macro spans in diagnostics output, we have to decouple some emitter.rs code first.

Relevant FIXME:

// FIXME(#59346): Add `fix_multispans_in_std_macros` function from emitter.rs

emitter.rs equivalent:

fn fix_multispans_in_std_macros(&mut self,

  • We first have to decouple the fix_multispans_in_std_macros
    method from EmitterWriter so that the code can be re-used in
    AnnotateSnippetEmitterWriter without duplicating it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsE-help-wantedCall for participation: Help is requested to fix this issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions