Skip to content

Unnecessary usage of intrinsics::copysignf32/64 in signum #61638

Description

@Centril

In f32::signum and f64::signum we use intrinsics::copysignf32 and intrinsics::copysignf64. However, these intrinsics are exposed with a stable wrapper f32::copysign and f64::copysign. We should use those instead.

unsafe { intrinsics::copysignf32(1.0, self) }

unsafe { intrinsics::copysignf64(1.0, self) }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions