Collector in trans is private

[MaikKlein]

I am currently trying to create a SPIR-V backend but I am running into a few problems.

For example https://github.com/rust-lang/rust/blob/master/src/librustc_trans/collector.rs is private https://github.com/rust-lang/rust/blob/master/src/librustc_trans/lib.rs#L108

It seems that a lot of useful functionality is inside collector.rs. Would it be possible to make some functionality public? I would be happy to provide a PR.

[eddyb]

It should be moved to to librustc_mir. cc @nikomatsakis @michaelwoerister

[michaelwoerister]

I think we'll need to turn it into a query soon anyway.

[eddyb]

That doesn't help, IMO. It should be a reusable piece of code. librustc_trans is the LLVM backend and therefore non-reusable.

[MaikKlein]

I talked with eddyb on irc about this issue.

• moving the collector to src/librustc_mir/monomorphize/collector.rs
• changing terminology from "trans collector" to "monomorphization collector"

I am happy to do a PR myself.