inotify-0.1.12 beta regression

[est31]

inotify version 0.1.12 regressed from stable to beta (full log):

Aug 03 06:35:42.006 INFO blam! ---- it_should_not_return_duplicate_events stdout ----
Aug 03 06:35:42.006 INFO blam! 	thread 'it_should_not_return_duplicate_events' panicked at 'assertion failed: `(left == right)`
Aug 03 06:35:42.006 INFO blam!   left: `0`,
Aug 03 06:35:42.006 INFO blam!  right: `1`', tests/main.rs:59:1
Aug 03 06:35:42.006 INFO blam! note: Run with `RUST_BACKTRACE=1` for a backtrace.

cc @hannobraun

[jonas-schievink]

fyi the newest version of inotify is 0.4.1, so this might just be a really old bug that was fixed

[est31]

@jonas-schievink it worked on the previous run. Maybe a spurious failure idk, but still filing a bug so that we dont miss it if it is a bug. Otherwise running tests would be pointless :)

[hannobraun]

I'm a bit hazy on the details, but I know there were spurious test failures in old versions that have been fixed since. I haven't looked into it, but I think it's unlikely that this is a regression in Rust.

I'm going to look into it.

[hannobraun]

I've tested inotify 0.1.12 with the lastest versions of stable, beta, and nightly, and I'm getting the same spurious failures in all of them. I think this can be closed.

@est31 Is there any way to blacklist the old inotify versions to prevent this from coming up again in the future? I'm not 100% sure, but I believe the spurious failure should be fixed from 0.2.0 onward.

[est31]

@hannobraun thanks for looking into this! I don't know whether blacklisting is supported. @tomprince do you know?

[arielb1]

#42541: the format of assert_eq messages changed. I don't think this is something we are going to guarantee stability on, or revert.

This is apparently fixed in newer versions of inotify.

[est31]

Oh that's it... It won't break then in the future I guess. Thanks all!

[hannobraun]

What does the format of assert_eq messages have to do with this issue? I'm confused now :-)