Skip to content

Current libc integration is a huge hack #42773

Description

@est31

Currently, the integration of the libc crate is very very hacky.

  1. Its integrated as git submodule, and not as cargo dependency.
  2. It is used via a shim (src/rustc/libc_shim) for the sole purpose of passing a cfg flag stdbuild to the crate.

I propose we revive the rustbuild feature that has been removed by #42495 and:

  1. Use libc from crates.io, without a shim, and removing the submodule
  2. Either use cargo features, or revive the rustbuild cfg flag removed by Bump to 1.20.0 and update stage0 compiler #42495 and use it instead of stdbuild

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions