…id_fixup-03, r=RalfJung Remove GetCurrentProcessId's frame_in_std check Most of the support required to close rust-lang#1727 was actually added a while back, in rust-lang#2215. However, for some reason, even though the Unix/Linux syscall equivalent has no `frame_in_std()` check, the Windows `GetCurrentProcessId` check did. While the vast majority of use cases use `std::process::id`, there's no particular reason to penalize any Windows code that is no_std or for whatever other reason choses to call the function directly (e.g. via the generated [windows-sys](https://docs.rs/windows-sys/latest/windows_sys/Win32/System/Threading/fn.GetCurrentProcessId.html) method). The emulation should still work fine. Given there's no reason not to, we might as well simplify the code a tiny bit and save that branch / frame check during runtime too. This PR removes the `frame_in_std` restriction for `GetCurrentProcessId`, and also moves it into the environment related shim section per discussion in rust-lang/miri#1727 (comment). Still passes existing tests/pass/getpid.rs test. Closes rust-lang#1727 unless we wish to give a dummy value when isolated, which we don't seem to want to do at this time.

Uh oh!

Uh oh!

make clean on mac fails to cleanup *.dSYM directories #2215

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions