Skip to content

typos-cli installed by bootstrap is slow #147331

Description

@Shunpoco

Summary

Discussion: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20Spellcheck.20check.20all.20files.3F/with/542621944

typos-cli installed by bootstrap for spellcheck is really slow.
I found that bootstrap adds -Copt-lvel=0 option for installing the tool. It affects the performance.

Command used

./x test tidy --extra-checks=spellcheck

Expected behaviour

Spellcheck in the tidy test finishes in some seconds

Actual behaviour

Spellcheck takes 10~ seconds

Operating system

Ubuntu 24.04

HEAD

595b9a4

Additional context

We've discussed that on CI we'd like to set the opt-level (0 or 1), but on local dev env we'd like to install the tool without the option.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions