Disable some tests - #554
Merged
Merged
Conversation
These tests require too much effort to maintain because the compiler is constantly changing its output. In the past it has caught some issues with the compiler breaking some things, but in general it hasn't caught anything in a very long time. Perhaps a different approach would be to simulate the compiler's output with fixed JSON so that version differences wouldn't matter. For now, I'm disabling the tests since I won't be able to maintain these anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests require too much effort to maintain because the compiler is constantly changing its output. In the past it has caught some issues with the compiler breaking some things, but in general it hasn't caught anything in a very long time. Perhaps a different approach would be to simulate the compiler's output with fixed JSON so that version differences wouldn't matter. For now, I'm disabling the tests since I won't be able to maintain these anymore.