Rustup to 1.9.0-nightly (30a3849f2 2016-03-30) - #821
Merged
Conversation
| Ok(ConstVal::Integral(Usize(Us64(i)))) => i as u32 as u64 != i, | ||
| Ok(ConstVal::Integral(Isize(Is64(i)))) => i as i32 as i64 != i, | ||
| Ok(ConstVal::Integral(ConstInt::Usize(ConstUsize::Us64(i)))) => i as u32 as u64 != i, | ||
| Ok(ConstVal::Integral(ConstInt::Isize(ConstIsize::Is64(i)))) => i as i32 as i64 != i, |
Contributor
There was a problem hiding this comment.
this change should not be necessary, but rather line 36 should be use rustc_const_math::*. I'm not sure why the unused import doesn't lint on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref rust-lang/rust#32259.