Skip to content

rustup https://github.com/rust-lang/rust/pull/62964 - #4302

Merged
bors merged 2 commits into
rust-lang:masterfrom
matthiaskrgr:rustup_13
Jul 27, 2019
Merged

rustup https://github.com/rust-lang/rust/pull/62964#4302
bors merged 2 commits into
rust-lang:masterfrom
matthiaskrgr:rustup_13

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

changelog: none

@matthiaskrgr

Copy link
Copy Markdown
Member Author

cc rust-lang/rust#62943

@Manishearth

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

📌 Commit f195550 has been approved by Manishearth

@bors

bors commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit f195550 with merge 483b9cc...

bors added a commit that referenced this pull request Jul 26, 2019
@bors

bors commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@matthiaskrgr

Copy link
Copy Markdown
Member Author

rustfmt is broken rust-lang/rustfmt#3703
I temporarily disabled it in CI

@ghost

ghost commented Jul 27, 2019

Copy link
Copy Markdown

You also might need to #[ignore] the fmt test.

diff --git a/tests/fmt.rs b/tests/fmt.rs
--- a/tests/fmt.rs
+++ b/tests/fmt.rs
@@ -1,4 +1,5 @@
 #[test]
+#[ignore]
 fn fmt() {
     if option_env!("RUSTC_TEST_SUITE").is_some() {
         return;

@matthiaskrgr

Copy link
Copy Markdown
Member Author

Done, thanks!

@phansch

phansch commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 65fbea4 has been approved by phansch

@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 65fbea4 with merge b26294d...

bors added a commit that referenced this pull request Jul 27, 2019
@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

💥 Test timed out

@matthiaskrgr

Copy link
Copy Markdown
Member Author

@bors retry

@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 65fbea4 with merge 0a81cdf...

bors added a commit that referenced this pull request Jul 27, 2019
@flip1995

Copy link
Copy Markdown
Member

I think travis lost track of this PR. Let's reopen it.

@flip1995 flip1995 closed this Jul 27, 2019
@flip1995 flip1995 reopened this Jul 27, 2019
@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 65fbea4 with merge 578f959...

bors added a commit that referenced this pull request Jul 27, 2019
@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

💥 Test timed out

@matthiaskrgr

Copy link
Copy Markdown
Member Author

Hmm, still can't find the corresponding build on travis https://travis-ci.com/rust-lang/rust-clippy/builds/ 😕

@matthiaskrgr

Copy link
Copy Markdown
Member Author

I probably messed up something in the ci config which fails to parse...

@matthiaskrgr

Copy link
Copy Markdown
Member Author

@bors r=phansch

@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

📌 Commit d73a953 has been approved by phansch

bors added a commit that referenced this pull request Jul 27, 2019
@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit d73a953 with merge 5441cf2...

@bors

bors commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 5441cf2 to master...

@bors
bors merged commit d73a953 into rust-lang:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants