[blocked] attempt to check rust-lang/rust with clippy in ci - #11235
Closed
matthiaskrgr wants to merge 34 commits into
Closed
[blocked] attempt to check rust-lang/rust with clippy in ci#11235matthiaskrgr wants to merge 34 commits into
matthiaskrgr wants to merge 34 commits into
Conversation
rustbot
added
the
S-waiting-on-review
matthiaskrgr
marked this pull request as draft
July 26, 2023 16:59
matthiaskrgr
changed the title
Member
Author
|
@bors try |
Contributor
bors
added a commit
that referenced
this pull request
Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci r? `@ghost` changelog: run clippy on rust-lang/rust as integration test
matthiaskrgr
force-pushed
the
rustc_in_ci
branch
from
July 26, 2023 17:03
a1292be to
0a79d65
Compare
Member
Author
|
@bors try |
Contributor
bors
added a commit
that referenced
this pull request
Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci r? `@ghost` changelog: run clippy on rust-lang/rust as integration test
Contributor
|
💔 Test failed - checks-action_test |
matthiaskrgr
force-pushed
the
rustc_in_ci
branch
from
July 26, 2023 17:15
e454122 to
5d592ce
Compare
Member
Author
|
@bors try |
Contributor
bors
added a commit
that referenced
this pull request
Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci r? `@ghost` changelog: run clippy on rust-lang/rust as integration test
matthiaskrgr
force-pushed
the
rustc_in_ci
branch
from
July 26, 2023 17:19
5d592ce to
5d0403c
Compare
Member
Author
|
@bors try |
Contributor
bors
added a commit
that referenced
this pull request
Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci r? `@ghost` changelog: run clippy on rust-lang/rust as integration test
Member
Author
|
wut that is outdated |
bors
added a commit
that referenced
this pull request
Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci r? `@ghost` changelog: run clippy on rust-lang/rust as integration test
matthiaskrgr
force-pushed
the
rustc_in_ci
branch
from
July 26, 2023 17:28
5d0403c to
fb39403
Compare
Member
Author
|
@bors try |
Contributor
bors
added a commit
that referenced
this pull request
Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci r? `@ghost` changelog: run clippy on rust-lang/rust as integration test
matthiaskrgr
force-pushed
the
rustc_in_ci
branch
from
July 26, 2023 17:48
fb39403 to
1818903
Compare
Member
Author
|
@bors try |
Contributor
bors
added a commit
that referenced
this pull request
Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci r? `@ghost` changelog: run clippy on rust-lang/rust as integration test
Contributor
|
💔 Test failed - checks-action_test |
matthiaskrgr
force-pushed
the
rustc_in_ci
branch
from
September 27, 2023 18:04
2f3d269 to
d8f5a04
Compare
Member
Author
|
@bors try |
Contributor
Contributor
|
💔 Test failed - checks-action_test |
Contributor
|
☔ The latest upstream changes (presumably #11929) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
Hey @matthiaskrgr, this is a ping from triage. Are you still working on this PR? |
Member
Author
|
I thiiink we can sunset it since there have been a lot of improvements in rustc including running clippy in ci there. unless someone else feels strongly and definitely wants this here? |
Contributor
|
I'm fine with how it is, but this is something @flip1995 might have some thoughts on since he does the syncs. Otherwise we can close this PR :) |
Contributor
|
Hey this is triage, I'm closing this due to inactivity. I think our current CI is sufficient and if not we can create a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @ghost
changelog: run clippy on rust-lang/rust as integration test
This might be blocked on at least
#11230
#11176
#11256