Skip to content

fix feature flags - #389

Merged
calebzulawski merged 2 commits into
rust-lang:masterfrom
RalfJung:const_intrinsic_copy
Feb 9, 2024
Merged

fix feature flags#389
calebzulawski merged 2 commits into
rust-lang:masterfrom
RalfJung:const_intrinsic_copy

Conversation

@RalfJung

@RalfJung RalfJung commented Feb 9, 2024

Copy link
Copy Markdown
Member

const_intrinsic_copy stabilization got reverted in rust-lang/rust#117905.

@RalfJung RalfJung changed the title re-add const_intrinsic_copy feature fix feature flags Feb 9, 2024
@RalfJung
RalfJung force-pushed the const_intrinsic_copy branch from 9827731 to 45f82c2 Compare February 9, 2024 21:06
@RalfJung

RalfJung commented Feb 9, 2024

Copy link
Copy Markdown
Member Author

Okay this is painful, we'll need a bunch of careful #[cfg] in the lib.rs that enables exactly the stdarch features needed for each configuration. Enabling features that don't exist for the current target just shows "unknown feature" errors...

@RalfJung
RalfJung force-pushed the const_intrinsic_copy branch from 438d26f to 047ba0a Compare February 9, 2024 21:20

@programmerjake programmerjake left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming it compiles everywhere, lgtm!

@calebzulawski
calebzulawski merged commit f505736 into rust-lang:master Feb 9, 2024
@calebzulawski

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants