Add #[non_exhaustive] documentation to TRPL. - #1955
Closed
davidtwco wants to merge 1 commit into
Closed
Conversation
7 tasks
Contributor
|
Hi there! First of all, thanks for this PR, and sorry for not replying sooner.
Yes, these kinds of things can be tricky. Unfortunately, we can only accept small changes to the book, and this feature requires too much new text. So I'm going to have to not accept this, not because it's not good (I didn't even read it), but due to those restrictions. Sorry about that :/ We will eventually decide if it goes in the book or not; I've opened #2093 to track this. Thank you and sorry again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for RFC 2008 (tracking issue rust-lang/rust#44109) to the reference. This feature is not yet stabilized, so this shouldn't be merged until that happens. This won't pass CI as the code examples use
#[non_exhaustive].I wasn't at all sure where to include documentation about this feature or how much to include. It requires some about of knowledge of structs, enums, privacy, external crates and pattern matching. I'm more than happy to move where it is and re-write parts that don't fit with the rest of the book, I tried to keep a consistent voice and style with the surrounding chapters.