Release 0.6.0 - #70
Merged
Merged
Conversation
|
r? @nastevens (rust-highfive has picked a reviewer for you, use r? to override) |
eldruin
force-pushed
the
release-0.6.0
branch
from
September 24, 2021 08:39
9805db6 to
dbe325d
Compare
Member
Author
|
bors try |
eldruin
force-pushed
the
release-0.6.0
branch
from
September 24, 2021 12:25
f6cbef5 to
c53a2b3
Compare
Member
Author
|
bors try |
Contributor
nastevens
reviewed
Sep 24, 2021
| //! ``` | ||
|
|
||
| #![cfg_attr(feature = "async-tokio", allow(deprecated))] | ||
| #![doc(html_root_url = "https://docs.rs/sysfs-gpio/0.6.0")] |
Member
There was a problem hiding this comment.
I don't think this is needed right? It seems like it'd be quickly out of date in any case.
Edit: I see the reminder in Cargo.toml so definitely intentional. Could you help me understand what this is doing please and why it's useful?
Member
Author
There was a problem hiding this comment.
Ah, this recommendation has been removed from the API guidelines: rust-lang/api-guidelines#230
I never liked it TBH. Thanks!
Member
|
bors r+ |
Contributor
|
👎 Rejected by too few approved reviews |
nastevens
approved these changes
Sep 24, 2021
nastevens
left a comment
nastevens
left a comment
Member
There was a problem hiding this comment.
Thanks for all the work you've been doing lately!
Member
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉