fix for issue #60 - #95
tanujitghosh wants to merge 1 commit into
Conversation
|
Good work! You're a natural at rust. One thing I would say is that hard-coding the workaround into the source is both inefficient (probably doesn't matter in this case as config parsing isn't performance sensitive), and makes the code more difficult to read. It's better if we can restructure the code so that the logic is correct. If we keep adding work-arounds into the source code we end up with code nobody can understand. |
|
🙇♂️ Thank you for your contribution. I apologize for the late response. Moving forward I want to re-think the design of I think ideally we want to have defaults be expressed as either:
The latter would work here if not for some strangeness with how the deserializer interacts with serde. |
This causes enough issues with zizmor
Hi,
I'm new to rust programming and learning it during my free time, wanted to contribute and learn at the same time.
I liked your library and wanted to help out
Worked on this issue #60 below.
Please review and provide your feedback