RUN-5040: Fix docsearch config: use indices instead of indexName - #1987
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The canonical DocSearch guide still documents the broken legacy configuration.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates DocSearch configuration for compatibility with @vuepress/plugin-docsearch rc.134.
Changes:
- Replaces legacy
indexNamewithindices. - Moves search parameters into the index configuration.
| File | Description |
|---|---|
docs/.vuepress/config.ts |
Migrates DocSearch to the required multi-index configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+134
to
+138
| searchParameters: { | ||
| hitsPerPage: 100, | ||
| facetFilters: [`version:${setup.base}`], | ||
| facets: ['tags'] | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Good catch, updated .claude/docs/docsearch-filters.md to show the indices wrapper (with a note about the rc.134 requirement), and also fixed the searchParameters references in .claude/docs/writing-style.md. Pushed in a5a1af1.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ltamaster
changed the title
Jesus-Osuna-M
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of undefined (reading 'map').@vuepress/plugin-docsearchrc.134 (bumped in 3cc0d8f) callsindices.map(...), but our config still used the legacyindexName+ root-levelsearchParameters, soindiceswas undefined.indices: [{ name: 'prod_rundeck_docs', searchParameters: {...} }]indocs/.vuepress/config.ts.Test plan
npm ci && npm run docs:dev, click Search: no console errorslang:<locale>facet filter the plugin adds per index doesn't filter everything out)Jira: RUN-5040
🤖 Generated with Claude Code