[RUN-0000] Remove unused js-yaml dependency from rundeck-cli - #173
Merged
Merged
Conversation
The QA CLI parses YAML exclusively with the `yaml` package (v2); there is no import of `js-yaml` anywhere in src/ or bin/. The `@types/js-yaml` entry was pinned at ^4.0.0 while `js-yaml` was at ^5.0.0, so the types did not even match the installed version. Nothing else in the tree depends on `js-yaml`, so the lock drops it along with its only transitive dependency, `argparse`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped dependency cleanup has no unresolved review comments.
Review effort: Lite
Findings: None
What changed in this PR
Removes unused js-yaml dependencies from the Rundeck QA CLI while retaining YAML parsing through yaml.
Changes:
- Removes
js-yamland@types/js-yaml. - Cleans lockfile entries, including unused
argparse.
| File | Description |
|---|---|
docker/client/rundeck-cli/package.json |
Removes unused dependencies. |
docker/client/rundeck-cli/package-lock.json |
Removes corresponding locked packages. |
Files not reviewed (1)
- docker/client/rundeck-cli/package-lock.json: Generated file
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 task
smartinellibenedetti
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
js-yamland@types/js-yamlfromdocker/client/rundeck-cli. Both are unused.Follow-up to the Copilot review on #169, which flagged the dependency as dead while Renovate was bumping its locked version.
Why
yamlpackage (v2) —src/lib/util.ts,src/commands/loadProject.ts,src/commands/addUsers.ts,src/commands/updateProjectsProperties.ts. There is nojs-yamlimport anywhere insrc/orbin/.@types/js-yamlwas pinned at^4.0.0whilejs-yamlwas at^5.0.0, so the types did not even correspond to the installed version — leftover from the migration toyaml.js-yaml, so it also drops its only transitive dependency,argparse.Verification
npm install --package-lock-onlyregenerates the lock with zerojs-yamlreferences and no other changes.npm ci+tsc --noEmiton the resulting tree: 0 errors insrc/. (The remaining errors are pre-existing and unrelated — TypeScript 3.8 cannot parse theundici-typesdeclarations shipped with@types/node24.)Note
This supersedes #169 — that PR only bumps the locked version of the package being removed here, so it can be closed.
Scope is limited to the QA client under
docker/; the published plugin artifact is unaffected.🤖 Generated with Claude Code