Improve dev setup - #1209
Improve dev setup#1209
Conversation
|
Bug with Google Maps? Uh? What kind problem do you have right now? (Btw, was already considering to move away from Google Maps. Maybe we’ll find some to discuss your needs?) |
|
@salzig sorry for no report, it's at #1210 but generally yeah the pin lands in the middle of the ocean: https://www.rug-b.de/events/september-meetup-2026-2729 |
We noticed on RUG::B that our latest locations weren't geocoded/ ended up in the middle of the ocean which was a bit odd. After looking into it, turns out that's due to the geocoding service used here requiring an HTTP header to identify yourself. So, that was added along with a couple of fail safes against the `nil`/`nil` -> 0/0 rendering. Based on the dev setup branch/#1209 since I needed those changes here.
We noticed on RUG::B that our latest locations weren't geocoded/ ended up in the middle of the ocean which was a bit odd. After looking into it, turns out that's due to the geocoding service used here requiring an HTTP header to identify yourself. So, that was added along with a couple of fail safes against the `nil`/`nil` -> 0/0 rendering. Based on the dev setup branch/#1209 since I needed those changes here.
d5009d4 to
9caa654
Compare
| # Settings specified here will take precedence over those in config/application.rb. | ||
| config.hosts << /.*onruby\.localhost.*/ | ||
| # for local development with the recommended domains | ||
| config.hosts << /.*onruby\.test.*/ |
There was a problem hiding this comment.
.test is not "recommended" anymore, but *.localhost is. For the simple fact that the later doesn't need any change in /etc/hosts`.
There was a problem hiding this comment.
I'm really interested in getting this branch done and would like to improve a bit the documentation to setup the platform locally. I hope it's okay that I take on hand and fix the things @PragTob.
I remove the .test from the commit, because we have since some time the .localhost solution that works way more smoothly. Also I will remove the one commit that got already deployed.
There was a problem hiding this comment.
Thanks, and sorry as per usual I was too busy with too many things so always happy for people to pick up stuff 😅
We noticed on RUG::B that our latest locations weren't geocoded/ ended up in the middle of the ocean which was a bit odd. After looking into it, turns out that's due to the geocoding service used here requiring an HTTP header to identify yourself. So, that was added along with a couple of fail safes against the `nil`/`nil` -> 0/0 rendering. Based on the dev setup branch/#1209 since I needed those changes here.
|
btw, I took the geocode commit and brought it live. Maybe you could clean up this mr a bit. |
9caa654 to
2be4959
Compare
JoschkaSchulz
left a comment
JoschkaSchulz
left a comment
There was a problem hiding this comment.
i corrected the commit meshup with the geocode fix. Now this should be fine.
2be4959 to
b2bcc7b
Compare
|
Looks good to me, thanks for the fixups folks and sorry for the delay! 
|
Wanted to work on a bugfix/investigation but in order to get there needed a couple of things which I think would be helpful for folks: * database seeds - I don't have access to heroku so having some basic data helps * documenting the login workaround a bit also helps getting started * many workarounds to try and make google maps work locally (my bug/gripe is in part with that) so allow to override the google maps key to be used for local dev
b2bcc7b to
6a39b56
Compare
3 participants
Wanted to work on a bugfix/investigation but in order to get there needed a couple of things which I think would be helpful for folks: