Skip to content

Add metrics for nested packs - #7

Merged
alexevanczuk merged 6 commits into
mainfrom
ae-nested-pack-stats
Aug 18, 2022
Merged

Add metrics for nested packs#7
alexevanczuk merged 6 commits into
mainfrom
ae-nested-pack-stats

Conversation

@alexevanczuk

@alexevanczuk alexevanczuk commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

This adds metrics for nested packs!

A couple of design decisions, framed around language:

  • every pack is in a pack group
  • a pack with no children is not a parent -- it is a standalone pack
  • a pack is only a parent if it's in a pack group with more than one member and its name is the name of the pack group
  • a pack is only a child if it's in a pack group with more than one member and it is not the parent

What this means:

  • pack group counts will go DOWN over time
  • the count of parents and children will go UP over time
  • Our DD dashboards should look at percent of packs that are parents or children (i.e. (parent packs + child packs)/total_packs).

@alexevanczuk
alexevanczuk requested review from a team and shageman August 18, 2022 13:36
@alexevanczuk
alexevanczuk merged commit 6e28096 into main Aug 18, 2022
@alexevanczuk
alexevanczuk deleted the ae-nested-pack-stats branch August 18, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant