Skip to content

Integrate error-stack for better error and stacktrace reporting - #4

Merged
mzruya merged 4 commits into
mainfrom
mz.error_improvments
Apr 2, 2023
Merged

Integrate error-stack for better error and stacktrace reporting#4
mzruya merged 4 commits into
mainfrom
mz.error_improvments

Conversation

@mzruya

@mzruya mzruya commented Apr 1, 2023

Copy link
Copy Markdown
Contributor

error-stack is a fairly recent Rust error reporting library meant to build richer and more concise error reports. Using it adds boilerplate and forces explicit error types across all fallible methods. The result is a much more concise and clear terminal output and the flexibility to customize error reporting by targeting an error happening deep inside the stack.

For example:
image

Or:
image

@mzruya
mzruya force-pushed the mz.error_improvments branch from 9a9c49c to 654c96b Compare April 1, 2023 19:48
@mzruya mzruya changed the title [Experiment] Use error-stack [Experiment] Integrate error-stack for better error and stacktrace reporting Apr 1, 2023
@mzruya mzruya changed the title [Experiment] Integrate error-stack for better error and stacktrace reporting Integrate error-stack for better error and stacktrace reporting Apr 1, 2023
@mzruya
mzruya force-pushed the mz.error_improvments branch 2 times, most recently from f885bde to d5e570a Compare April 2, 2023 16:31
@mzruya
mzruya force-pushed the mz.error_improvments branch from d5e570a to 5951099 Compare April 2, 2023 16:59
@mzruya
mzruya merged commit 9eb1be7 into main Apr 2, 2023
@mzruya
mzruya deleted the mz.error_improvments branch April 2, 2023 17:10
dduugg added a commit that referenced this pull request Aug 17, 2026
Resolves the eight open `actions/missing-workflow-permissions` CodeQL
alerts (#1, #3, #4, #5, #6, #7, #8, #9). Every job now has an effective
`permissions:` block scoped to what it actually does.

ci.yml
  Workflow-level `contents: read` covers `check`, `test` and `lints`,
  which only check out the repo and run cargo check/test/fmt/clippy.

  Four jobs override to `contents: write` because they mutate releases:
  - `release` runs `gh release create --generate-notes`
  - `upload-mac-universal-bin` and `upload-linux-bin` run
    `gh release upload` to attach the built tarballs
  - `generate-dotslash-files` uses facebook/dotslash-publish-release,
    which also publishes via `gh release upload`

audit.yml
  `rustsec/audit-check` needs `checks: write` to publish the advisory
  status check on push/pull_request runs and `issues: write` to open an
  issue per new advisory on the weekly scheduled run (both documented in
  the action's README). `contents: read` covers actions/checkout. It
  does not upload SARIF, so no `security-events: write`.

codeql.yml already declares permissions and is untouched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant