Remove bccwin and AmigaOS from the OS code detection - #148
Merged
Merged
Conversation
Ruby 2.3 dropped Borland C. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AmigaOS is not a platform Ruby supports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forward-ports the zlib part of ruby/ruby#19010, which removed leftover code for platforms Ruby no longer supports.
extconf.rbno longer matchesbccwinand drops theamigaosbranch.Zlib::OS_AMIGAstays because it is a gzip header value, and--with-os-code=amigastill works.Both commits keep their original author and date, and
ext/zlib/extconf.rbnow matches ruby/ruby byte for byte. On mswin,rake compile testpasses and extconf still detects Win32, soZlib::OS_CODEisZlib::OS_WIN32.Generated with Claude Code