Repository navigation
installer.rb - fix #windows_stub_script - #2876
Merged
1 commit merged intoAug 16, 2019
Merged
1 commit merged into
1 commit merged into
Conversation
use ruby_exe in heredocs instead of ruby.exe
1 of 5 tasks
deivid-rodriguez
approved these changes
Aug 16, 2019
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
Contributor
There was a problem hiding this comment.
The OP has confirmed this fixes the issue, and this sounds like hard to test (Windows + jruby specific bug). So I'm good with this! 👍
Member
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Aug 16, 2019
2876: installer.rb - fix #windows_stub_script r=hsbt a=MSP-Greg
Use ruby_exe in heredocs (scripts) instead of ruby.exe. Currently, binstubs only work for standard MRI exe ('ruby.exe').
See Issue #2873
# Tasks:
- [X] Describe the problem / feature
- [ ] Write tests
- [X] Write code to solve the problem
- [ ] Get code review from coworkers / friends
I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Co-authored-by: MSP-Greg <msp-greg@users.noreply.github.com>
Build succeeded |
hsbt
pushed a commit
that referenced
this pull request
Feb 18, 2020
2876: installer.rb - fix #windows_stub_script r=hsbt a=MSP-Greg
Use ruby_exe in heredocs (scripts) instead of ruby.exe. Currently, binstubs only work for standard MRI exe ('ruby.exe').
See Issue #2873
# Tasks:
- [X] Describe the problem / feature
- [ ] Write tests
- [X] Write code to solve the problem
- [ ] Get code review from coworkers / friends
I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Co-authored-by: MSP-Greg <msp-greg@users.noreply.github.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ruby_exe in heredocs (scripts) instead of ruby.exe. Currently, binstubs only work for standard MRI exe ('ruby.exe').
See Issue #2873
Tasks:
I will abide by the code of conduct.