Repository navigation
Conversation
Appending a search domain can take a relative name past the 255 octet limit. The query was still sent, and because the decoder rejects a name that long in the reply, the lookup sat until the timeout before trying the next candidate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a relative name fits in 255 octets but appending a search domain pushes it over,
Resolv::DNSstill sends the query for that candidate. The decoder rejects a name that long in the reply, so the lookup waits out the whole timeout before trying the next candidate. With the default timeouts and one nameserver, a singlegetaddressstalls for 150 seconds.This skips such a candidate in
Config#generate_candidatesand goes on with the remaining ones. Candidates within 255 octets are unchanged. I left the encoder alone, becausegenerate_candidatesis the only place that builds a longer name out of a valid one.Generated with Claude Code