Fix herb linter offenses in ERB templates - #1645
Merged
Merged
Conversation
- Remove `then` keyword from all ERB control flow tags (52 offenses) - Move duplicated elements outside conditional branches (14 offenses) - Add .herb.yml to disable rules not applicable to RDoc templates: erb-no-instance-variables-in-partials (not Rails partials), erb-no-unsafe-script-interpolation (trusted data), erb-no-output-in-attribute-position (trusted data)
Collaborator
|
🚀 Preview deployment available at: https://3bf415c6.rdoc-6cd.pages.dev (commit: 3af977b) |
st0012
marked this pull request as ready for review
March 14, 2026 14:10
tompng
approved these changes
Mar 14, 2026
k0kubun
pushed a commit
that referenced
this pull request
May 12, 2026
- Remove `then` keyword from all ERB control flow tags (52 offenses) - Move duplicated HTML elements outside conditional branches (14 offenses) - Add `.herb.yml` config to disable rules not applicable to RDoc: - `erb-no-instance-variables-in-partials` — RDoc templates aren't Rails partials - `erb-no-unsafe-script-interpolation` — templates render trusted RDoc data - `erb-no-output-in-attribute-position` — same reason Fixes CI failure caused by `@herb-tools/linter` 0.9.0 introducing new rules.
k0kubun
pushed a commit
that referenced
this pull request
May 12, 2026
- Remove `then` keyword from all ERB control flow tags (52 offenses) - Move duplicated HTML elements outside conditional branches (14 offenses) - Add `.herb.yml` config to disable rules not applicable to RDoc: - `erb-no-instance-variables-in-partials` — RDoc templates aren't Rails partials - `erb-no-unsafe-script-interpolation` — templates render trusted RDoc data - `erb-no-output-in-attribute-position` — same reason Fixes CI failure caused by `@herb-tools/linter` 0.9.0 introducing new rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thenkeyword from all ERB control flow tags (52 offenses).herb.ymlconfig to disable rules not applicable to RDoc:erb-no-instance-variables-in-partials— RDoc templates aren't Rails partialserb-no-unsafe-script-interpolation— templates render trusted RDoc dataerb-no-output-in-attribute-position— same reasonFixes CI failure caused by
@herb-tools/linter0.9.0 introducing new rules.