Restore SingleLine group state after early exits - #23
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore SingleLine's group/first-item stack when a group exits through an exception, throw, return or break, including an exception raised by the output sink. Normal output and the existing boolean return value remain unchanged.
Reproduction
Verification
rake test, 35 tests / 54 assertions, passes before/after.Breaking-change notes
No API removal or normal-output change. A printer reused after an interrupted group now sees the restored parent state. Already-emitted output is not rolled back, and a closing delimiter is not synthesized after failure.