Skip to content

Move parse_command method to Context - #993

Merged
tompng merged 1 commit into
masterfrom
move-parse-command-to-context
Aug 27, 2024
Merged

tompng merged 1 commit into
masterfrom
move-parse-command-to-context

Conversation

@st0012

@st0012 st0012 commented Aug 25, 2024

Copy link
Copy Markdown
Member

Since Context dictates whether a line is a command or an expression, moving the parse_command method to Context makes the relationship more explicit.

Since Context dictates whether a line is a command or an expression,
moving the parse_command method to Context makes the relationship
more explicit.
@st0012 st0012 self-assigned this Aug 25, 2024
@st0012 st0012 mentioned this pull request Aug 25, 2024

@tompng tompng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tompng
tompng merged commit 9a4487a into master Aug 27, 2024
@tompng
tompng deleted the move-parse-command-to-context branch August 27, 2024 12:49
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 27, 2024
(ruby/irb#993)

Since Context dictates whether a line is a command or an expression,
moving the parse_command method to Context makes the relationship
more explicit.

ruby/irb@9a4487af61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants