Repository navigation
Refactor eval history - #623
Merged
Merged
Conversation
To confusion with `lib/irb/history.rb`
st0012
force-pushed
the
refactor-eval-history
branch
from
July 3, 2023 17:24
e1ad483 to
4249ca6
Compare
tompng
approved these changes
Jul 4, 2023
tompng
left a comment
tompng
left a comment
Member
There was a problem hiding this comment.
Looks good!
could be easily confused with IRB's history saving feature
renaming 👍
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 4, 2023
(ruby/irb#623) * Rename `ext/history.rb` to `ext/eval_history.rb` To confusion with `lib/irb/history.rb` * Add eval_history tests * Rename eval_history's History to EvalHistory to avoid confusion
mvz
added a commit
to cucumber/aruba
that referenced
this pull request
Dec 24, 2023
See ruby/irb#623. The file was removed and the corresponding feature should be activated by setting :EVAL_HISTORY.
This was referenced Aug 3, 2026
znz
added a commit
to rurema/doctree
that referenced
this pull request
Aug 3, 2026
#3408 の残タスク 2 件。 - lib/irb/ext/history.rb は Ruby 3.3.0 で ext/eval_history.rb に改名 (ruby/irb#623。3.2.9 まで旧名)。history.md に until: "3.3" を付け、 同内容の eval_history.md(since: "3.3")を新設して文書を引き継ぐ。 extend-command.md の require も版分岐(3.3 の実装は eval_history を 参照している) - IRB::ReadlineInputMethod の include ::Readline は irb 1.15.2 で廃止 (ruby/irb#1076。const_set 方式+readline 不在時は Reline に フォールバック)。Ruby 4.0.0 は irb 1.16.0 を bundled gem として 同梱するため 4.0 から乖離 → front matter の include を #%until 4.0 でゲートし、本文の「require 失敗時は定義されない」も版分岐 検証: 境界版(3.2/3.3/4.0)の DB で存否・require・include・ IRB::Context#eval_history の継続を機械確認・checklink 死リンクゼロ。 メソッド単位バッジはライブラリ無視で名前 union のため改名で途切れない。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was not enabled by default, not tested, and could be easily confused with IRB's history saving feature. So in this PR I did these improvements:
limit - 1results, which is probably a bug. But since it's not widely used and we don't have any reports about it, I don't prioritise fixing it atm.