A method what is named with an encoding what is incompatible with Encoding.default_external causes crash #52

Activity

1. aycabta

   changed the title [-]A method what is named with an encoding what is different from `Encoding.default_external` causes crash[/-] [+]A method what is named with an encoding what is incompatible with `Encoding.default_external` causes crash[/+] on Jan 9, 2020
2. alexanderadam

   added 8 commits that reference this issue on Oct 21, 2025

   fix: don't crash on utf18 autocompletion

   ...

   This issue will close once commit 1c50bc8 is merged into the 'master' branch.

   1c50bc8

   fix: don't crash on utf18 autocompletion

   ...

   This issue will close once commit 2759a0a is merged into the 'master' branch.

   2759a0a

   fix: don't crash on utf18 autocompletion

   ...

   This issue will close once commit 0550394 is merged into the 'master' branch.

   0550394

   fix: don't crash on utf18 autocompletion

   ...

   This issue will close once commit 795b975 is merged into the 'master' branch.

   795b975

   fix: don't crash on utf18 autocompletion

   ...

   This issue will close once commit 6ed23be is merged into the 'master' branch.

   6ed23be

   fix: don't crash on utf18 autocompletion

   ...

   This issue will close once commit a5d05eb is merged into the 'master' branch.

   a5d05eb

   fix: don't crash on utf18 autocompletion

   ...

   This issue will close once commit b648d18 is merged into the 'master' branch.

   b648d18

   Fix UTF-16 autocompletion

   ...

   This issue will close once commit 84663b1 is merged into the 'master' branch.

   84663b1
3. eregon commented on Oct 27, 2025

   

   eregon

   on Oct 27, 2025

   Member

   More actions

   IMO it's unreasonable and pointless to define a method with a UTF-16 name, see truffleruby/truffleruby#4005 (comment).
   I think CRuby should actually prevent defining such a method in a dummy (Encoding::UTF_16) or ASCII-incompatible encoding (Encoding::UTF_16LE/Encoding::UTF_16BE).
4. alexanderadam commented on Oct 27, 2025

   

   alexanderadam

   on Oct 27, 2025

   Contributor

   More actions

   I think CRuby should actually prevent defining such a method in a dummy (Encoding::UTF_16) or ASCII-incompatible encoding (Encoding::UTF_16LE/Encoding::UTF_16BE).

   What would you like to see?
   A particular exception thrown?
5. alexanderadam

   added a commit that references this issue on Oct 27, 2025

   Fix UTF-16 autocompletion

   ...

   This issue will close once commit fed1886 is merged into the 'master' branch.

   fed1886
6. eregon commented on Oct 28, 2025

   

   eregon

   on Oct 28, 2025

   Last edited by eregon

   Member

   More actions

   All 3 UTF-16 encodings are ASCII-incompatible:

   irb(main):001> Encoding::UTF_16.ascii_compatible?
   => false
   irb(main):002> Encoding::UTF_16LE.ascii_compatible?
   => false
   irb(main):003> Encoding::UTF_16BE.ascii_compatible?
   => false
   

   And Ruby only supports sources in ASCII-compatible encodings:

   $ ruby -e '# encoding: utf-16le'
   -e:1: UTF-16LE is not ASCII compatible (ArgumentError)
   

   So I think either an ArgumentError or maybe Encoding::CompatibilityError when define_method receives a name in an ASCII-incompatible encoding.
   For example filesystem operations reject such ASCII-incompatible encodings:

   irb(main):004> File.read("abc".encode(Encoding::UTF_16LE))
   (irb):4:in `read': path name must be ASCII-compatible (UTF-16LE): "abc" (Encoding::CompatibilityError)
   	from (irb):4:in `<main>'
   	from <internal:kernel>:187:in `loop'
   	from /home/eregon/.rubies/ruby-3.3.5/lib/ruby/gems/3.3.0/gems/irb-1.13.1/exe/irb:9:in `<top (required)>'
   	from /home/eregon/.rubies/ruby-3.3.5/bin/irb:25:in `load'
   	from /home/eregon/.rubies/ruby-3.3.5/bin/irb:25:in `<main>'
   
7. tompng

   added a commit that references this issue on Oct 28, 2025

   Fix UTF-16 autocompletion (#1129)

   ...

   This issue will close once commit 18d152b is merged into the 'master' branch.

   18d152b
8. tompng

   closed this as completedin #1129on Oct 28, 2025
9. alexanderadam

   added 3 commits that reference this issue on Oct 28, 2025

   update test to check for UTF16/LE/BE

   ...

   This issue will close once commit 53acae1 is merged into the 'master' branch.

   53acae1

   update test to check for UTF16/LE/BE

   ...

   This issue will close once commit 078782c is merged into the 'master' branch.

   078782c

   update test to check for UTF16LE

   ...

   This issue will close once commit 7af1008 is merged into the 'master' branch.

   7af1008
10. tompng

    added 2 commits that reference this issue on Nov 19, 2025

    update test to check for UTF16LE

    ...

    This issue will close once commit 04fa9eb is merged into the 'master' branch.

    04fa9eb

    update test to check for UTF16LE (#1132)

    ...

    This issue will close once commit dfb89f2 is merged into the 'master' branch.

    dfb89f2