Net::LDAP#open does not cache bind result - #331
Closed
vroldanbet wants to merge 5 commits into
Closed
Conversation
may have broken in the most recent slapd version for Ubuntu Xenial?
aligns implementation of open with other methods, so the result becomes accessible via get_operation_result
Contributor
Author
|
In 8135bbe we can see the 🐛 manifesting. It expected code In dd2a880 the test goes green after introducing the fix in cb4b48c Unfortunately CI is broken. I tried to address it, but it seems TLS configuration is not being set properly, and so TLS integration tests are failing 😭 |
Contributor
Author
|
I'm addressing CI build in #333 |
Contributor
Author
|
Superseded by #334, which contains the fixed CI build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We identified that clients cannot safely rely on
Net::LDAP#get_operation_resultwhen usingNet::LDAP#openbecause@resultis not set.As a consequence, clients calling
Net::LDAP#get_operation_resultwould get the previous cached@result. Yikes.