Skip to content

Refactor install script and support Raspberry Pi 4 - #62

Merged
ShotaAk merged 2 commits into
masterfrom
feature/raspi4-install-script
Dec 15, 2020
Merged

ShotaAk merged 2 commits into
masterfrom
feature/raspi4-install-script

Conversation

@Tiryoh

@Tiryoh Tiryoh commented Dec 7, 2020 •

Copy link
Copy Markdown
Contributor

What does this implement/fix?

  • ビルド成功時でも"ERROR"の文字列を含むログが出力され、誤解を招きます。エラーが出なければ最小限の出力となるように変更しています。
  • コメントと改行を追加してスクリプトを見やすくしています。
  • Raspberry Pi 4の場合は自動でrtmouse.c内のオプションを書き換えるようにしています。
$ ./utils/build_install.bash 
make -C /usr/src/linux-headers-5.4.0-1023-raspi M=/home/ubuntu/RaspberryPiMouse/src/drivers V=0 clean
make[1]: Entering directory '/usr/src/linux-headers-5.4.0-1023-raspi'
  CLEAN   /home/ubuntu/RaspberryPiMouse/src/drivers
  CLEAN   /home/ubuntu/RaspberryPiMouse/src/drivers/Module.symvers
make[1]: Leaving directory '/usr/src/linux-headers-5.4.0-1023-raspi'
make -C /usr/src/linux-headers-5.4.0-1023-raspi M=/home/ubuntu/RaspberryPiMouse/src/drivers V=0 modules
make[1]: Entering directory '/usr/src/linux-headers-5.4.0-1023-raspi'
  CC [M]  /home/ubuntu/RaspberryPiMouse/src/drivers/rtmouse.o
  Building modules, stage 2.
  MODPOST 1 modules
  CC [M]  /home/ubuntu/RaspberryPiMouse/src/drivers/rtmouse.mod.o
  LD [M]  /home/ubuntu/RaspberryPiMouse/src/drivers/rtmouse.ko
make[1]: Leaving directory '/usr/src/linux-headers-5.4.0-1023-raspi'

Does this close any currently open issues?

いいえ

How has this been tested?

Raspberry Pi Mouse実機にて動作確認をしています。

Any other comments?

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh added Type: Refactoring A code change that neither fixes a bug nor adds a feature Type: Feature New Feature and removed Type: Refactoring A code change that neither fixes a bug nor adds a feature labels Dec 7, 2020
@Tiryoh
Tiryoh requested a review from ShotaAk December 7, 2020 06:52

@ShotaAk ShotaAk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raspberry Pi 4 と、Ubuntu 18.04 & Raspbian (10) で動作確認しました。
良いと思います。

1箇所修正お願いします。

Comment thread utils/build_install.bash Outdated
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
@Tiryoh
Tiryoh requested a review from ShotaAk December 15, 2020 01:59
@ShotaAk
ShotaAk merged commit a9af4fa into master Dec 15, 2020
@ShotaAk
ShotaAk deleted the feature/raspi4-install-script branch December 15, 2020 05:08
@Tiryoh Tiryoh mentioned this pull request Dec 15, 2020
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants