feat(review): add Git change review tabs - #79
Open
JairEsk wants to merge 11 commits into
Open
Conversation
- Purged Review tab types and methods from api.ts and preload/index.ts. - Restrained Review IPCs to only be callable by the main window for security. - Fixed Git path traversal vulnerability in stageFiles and unstageFiles. - Removed Review UI implementations and states from BrowserChrome.tsx. - Cleaned up typecheck errors across web and node.
Long lines now scroll sideways instead of wrapping, and the scrollbar is actually visible: the diff renders in a shadow root, so main.css never reached it and the library's own handle stayed transparent until hover. Restyle it there with the same tokens. Also aligns the pane header below the window controls, extracts the resize bounds to constants, matches the close button to LoopDetailsPane, and removes patch scripts committed by mistake.
The review-tab block in smoke.ts calls browser.newReviewTab(), which was removed in 6ab2e7a when Review moved out of the browser window and into the chat pane, so it failed on all three OSes with '(void 0) is not a function'. Five files touched by this branch were never run through prettier, failing format:check.
… constants runCodeReview inlined 50000 at its call site while tools.ts keeps every other output cap together at the top; the commit-picker clamp was spelled out twice in main plus a bare 30 in the renderer; and the scope union was re-typed by hand next to an existing GitReviewScope.
FreddyJD
marked this pull request as draft
August 29, 2026 18:15
…-diffs-findings # Conflicts: # package.json # src/renderer/src/browser/BrowserChrome.tsx # src/renderer/src/browser/main.tsx
JairEsk
marked this pull request as ready for review
August 30, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run buildnpm run smokenpm run smoke:review(49 checks)git diff --check