Repository navigation
Conversation
Covers the one-click removal the Totals do not match warning now offers, the Fill action for a token held in several locations, and why lowering totals by hand around a spam token breaks the graph. Also brings the page in line with 1.44.1: a stale total opens as an unsaved change, Show spam alone reveals spam rows, and reconcile no longer preselects a location.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents rotki/rotki#13257 on the snapshots page, for the 1.44.1 patch line.
New: Remove a high-value spam token
Replaces the old example, which walked through reconciling first and then deleting the row.
It is now its own section, since it no longer goes through reconciling.
Brought in line with 1.44.1
These describe behaviour that changed in rotki/rotki#13243 and #13257:
Checks
pnpm run lint,check:anchors,check:imagesandcheck:app-linkspass. No images changed; the existing delete dialog screenshot still matches.bugfixeswas fast-forwarded tomainbefore branching, so it already has the reconcile section from #147.